On Mon, Mar 16, 2009 at 11:17:41AM +0100, Jan Rychter wrote: > > Robin Lee Powell <[email protected]> writes: > > On Sun, Mar 15, 2009 at 06:23:06PM +0100, Jan Rychter wrote: > >> > >> I would like to ask for agreement on how we specify > >> selected/disabled (and hidden) panes for render-menu. In my > >> trees they were specified by uri-token, not the human-readable > >> name. I had a very good reason for that: it's consistent, it's > >> precise, and I didn't have any issues with menu items that have > >> names with non-ASCII characters in them. Things worked fine, > >> but now as I transition to the latest weblocks-dev I find that > >> things are broken again. > >> > >> Could we please agree that all render-menu arguments (except > >> for the car in option cells) use tokens, not names? Is this a > >> problem for anyone? > > > > For those of us that are behind the curve, can you give more > > detail? A code example of the two approaches would be especially > > nice. > > It's about the API to the render-menu function -- I believe we > should use human-readable names only for human-visible output, all > the rest of the API should use uri-tokens. This means that when > you specify what the :selected-pane is, you pass it > (static-selector-current-pane obj) (see widgets/navigation.lisp), > you don't look for the human-readable name.
I really work best with code examples. I'd really like to see one. In general, though, I agree that human-readable names are for humans; code should use unique ids of some kind that are easy for the code to deal with. -Robin -- They say: "The first AIs will be built by the military as weapons." And I'm thinking: "Does it even occur to you to try for something other than the default outcome?" -- http://shorl.com/tydruhedufogre http://www.digitalkingdom.org/~rlpowell/ *** http://www.lojban.org/ --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "weblocks" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/weblocks?hl=en -~----------~----~----~----~------~----~------~--~---
