Hi Dan, Thanks for all of your help on this, I really appreciate your patience, couple of fixes inline below.
Dan Price wrote: > On Wed 13 Aug 2008 at 02:27PM, Michelle Olson wrote: > >> Hi all, >> >> Thanks to everyone who contributed to the update of the home page, about >> pages, and many other common areas of our web site over the last month. >> I really appreciate the time and energy you all spent to review and >> feedback and contribute. I feel confident that I've resolved all the >> P3's and above. Here is the final version that I will implement today: >> >> http://stage.opensolaris.org/os/ >> >> I have to implement today to avoid losing our changes and/or holding up >> the server migration another day. If you find bugs or problems, do send >> them along, this is an ongoing work in progress and all comments and >> feedback are welcome. >> > > Site navbar: descenders (like 'p' and 'g') should not cross over the > navbar border. Suggest not using default blue for those links, > I think it's distracting. I think if you styled this with: > > height: 12pt; > line-height: 11pt; > > To div.osol__top__div, it would probably fix it. I tried it, and > it looked good in firefox, at least. Thanks Dan, I think I have this fixed now. Let me know what you think of the color, I just guessed. > The problem here is that in > the <body> styling in elements.css, line-height is set to 1.5em for > the whole page: > > body { > padding: 1em; > margin: 0; > background-color: white; > font-size: 75.01%; /* 12px [1] */ > -----> line-height: 1.5em; /* 18px [2] */ > color: black; > font-family: "Trebuchet MS", sans-serif; > } > > And so when you want to be precise you have to at times override > this. > > Top navbar: top and bottom margins aren't the same for the "Discussions" > "Communities", etc-- there's not enough whitespace at the top. A few > extra pixels will make a big difference. > Right, these are very squished right now and more so to make room for the p's and g's in the ribbon nav, but I think it is still OK. > Middle column: Suggest that it get a little wider margin, providing a > little more separation. > > Feature Spot: Recommend continuing work to make this a little more > graphically appealling. > Agreed, I'm working on this. > Sun-Sponsored links: Virtualbox graphic is impressively ugly, I realize > that's not your call, but, still. > This is fixed, thanks to Glynn. -Michelle _______________________________________________ website-discuss mailing list website-discuss@opensolaris.org
