Hi Christian, *

Am 16.04.2013 16:36, schrieb Christian Lohmaier:
> So it was you I had the mid-air collision with :-)

yup, trying to be clever here and there ...  ;)
had the feeling anyways that it could be risky.


>> if(strlen($target) > 180)   was 150  (line 11)
> 
> unnecessary/"wrong" as iso-URLs are shorter than regular ones. Longest
> ones are the Linux x86-64 rpm langpacks at 131 characters.

Hm, wasn't sure if it counts the whole string or only the addition after
the ? and counted 177 chars for the 402 DVD all together ... thought it
wouldn't hurt anybody to increase this number a little  ;)


>> if(substr_count($target,"/") < 6)   was 7  (line 14)
> 
> I had changed the de one to use a regular expression match instead,
> and when going on to the en-one I had vim telling me the file has been
> modified since I opened it, so I backed off and let the unknown editor
> do the change :-))

Surely preferable ... can't handle them properly  :/
so it was just this one, alright.

... always look at the bright side of life ...  :-)

ciao
Erich

-- 
Unsubscribe instructions: E-mail to [email protected]
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://listarchives.libreoffice.org/global/website/
All messages sent to this list will be publicly archived and cannot be deleted

Reply via email to