Updated webrevs are posted on http://cr.opensolaris.org/~sunandam/6711903 .
The /usr/mysql/5.1 binaries should be with permissions 555 in my opinion
and not 444 .Since they are handled in the install scripts ,no changes
have been done .
I have made all other changes .Please review .
Thanks Sunanda
Sriram Natarajan wrote:
> - Any reason, why mysql 5.1 cannot be compiled with -x04 considering
> that MySQL 5.0 is currently compiled with this option within
> OpenSolaris SFW ?
> - should '-xtarget=generic' compiler flags be applicable for C++ as
> well. currently, it doesn't seems to be.
> - I see this line within Makefile.sfw ..
> --with-server-suffix= \
>
> do we need this option, if no arguments are going to be entered here
>
> - do you really need this line. i would rather not have this line but
> investigate and fix as to why a core dump comes in first place.
>
> find . -name core -exec rm -f {} \;
>
> - in this below line, any particular reason that you expect the files
> to not have 'r' permission ? also, the new convention is to deliver
> 444 files in /usr/mysql/5.1. so, you might want to remove 'w' for
> users/group and others as well.
>
> find $(MYSQL_DIR) -type f -exec /usr/bin/chmod ugo+r "{}" \;
>
>
> - Will MySQL 5.1 server start in 64 bit, if the OS is running in 64-bit ?
>
> - You probably don't need a depend file for SUNWmysql51r. you could
> use the default provided by SFW.
>
> - Not including the full version information within pkginfo.tmpl,
> depend files (for eg : instead of mentioning as 5.1.30 but simply
> leaving it as 5.1) will allow you to easily update from one version to
> another.
>
>
> Do you plan to deliver this for build 109 ? If yes, can PHP depend on
> MySQL 5.1 client libraries. This would allow users to download MySQL
> 5.1 client libraries only as part of PHP instead of the current way of
> having to download the entire MySQL server if they need to try out PHP
>
> thanks
> sriram
>
>
> sunanda menon wrote:
>> Hi ,
>>
>> Please review the MySQL 5.1 Integration with dtrace enabled at
>> http://cr.opensolaris.org/~sunandam/6711903/
>>
>> The RFE's/bugs incorporated our
>>
>> 6711903,6697133 ,6761696 and 6728729
>>
>>
>> Thanks Sunanda
>> _______________________________________________
>>
>>
>> webstack-discuss mailing list
>> webstack-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
