On 02/24/09 22:31, Jeff Trawick wrote: > Seema Alevoor wrote: >> Hi, >> >> Webrev for the following CRs is at >> http://cr.opensolaris.org/~seema/6761354/ >> 6774187 APR and HTTPD build files contain hard-coded compiler path > > This issue bugs me a bit. Installing SUNWgcc puts cc in the default > PATH, and that cc won't handle our cflags (and apxs/apr-1-config should > use a compiler matching the build anyway). > > Two compilers are delivered with OpenSolaris: > SUNWgcc in /usr/gnu/bin and sunstudioexpress in > /opt/SunStudioExpress/prod/bin > That is why the cc path was hardcoded in earlier releases (/opt/SUNWspro/bin was the default path before IPS package was introduced). But there were users who preferred non-hardcoded value.
> The latter is the one which is suitable for use. The current hard-coding > of /opt/SUNWspro doesn't match either of those. > Yeah...since /opt/SUNWspro/bin is no longer the default path. > A few possible changes: > > 1. Hard-code /opt/SunStudioExpress... instead of /opt/SUNWspro > > at least the possible error message can be deciphered by non-cflag-savants > > 2. Use plain cc but also catch when cc in path isn't some SunStudio > > there could be multiple places where a check would be required (aren't > apxs and apr-1-config based on separate definitions?) > I think a combination of above two would be a better option. As suggested by Basant (but with the reverse logic), first check for cc in the path. If it is Sun compiler use it. Else check for /opt/SunStudioExpress/bin. If not found, check in /opt/SUNWspro/bin. > 3. Use plain cc alone, help out with "-mt is invalid flag" and other > such error messages > We can also handle this with a two step approach. For this release, have it as "cc" without additional checks and let us document the need for Sun Studio compiler in the path. Then in the subsequent release, add additional checks to reduce the possibility of non-Sun compiler usage. > (I haven't checked if the current changes address both apr-1-config and > apxs.) It does. > This issue is worth discussion to see if there are more ideas and select > the best trade-offs. > > > >> 6761354 [nvb100] : build files of APR, APR-Util and HTTPD contain >> build environment specific paths > > I haven't worked through this one yet :( > >> 6800638 Support exception hook in Apache HTTP Server > > change looks okay > Thanks. Regards, Seema. > > _______________________________________________ > > > webstack-discuss mailing list > webstack-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
