looks good to me
Amanda Waite wrote:
> Hi again,
>
> Thanks for the reviews so far. One more round required though. Updated
> WebRev is here: http://cr.opensolaris.org/~tekgrrl/CR-6816914/
>
> I removed the harcoded path to the MySQL 5.1 libs and mysql_config in
> Makefile.sfw. It now uses the symlinks instead. Because lighttpd uses
> mysql_config for it's LDFLAGS the RPATH will still be hardcoded to the
> version it was built with which is as it should be.
>
> Thanks
>
> Amanda
>
> Amanda Waite wrote:
>> Hi there,
>>
>> Could you kindly review the following update to Lighttpd:
>>
>> http://cr.opensolaris.org/~tekgrrl/CR-6816914/
>>
>> Updating Lighttpd to use the MySQL 5.1 libraries also fixes 3 other
>> issues. Lighttpd no longer has a build time dependency on
>> /usr/sfw/bin/mysq_config and the Lighttpd package dependency is now
>> for the MySQL 5.1 library package and not the whole of MySQL. The
>> last fix was just a case of removing any reference to /usr/sfw/lib as
>> Lighttpd no longer needs it.
>>
>> LIGHTTPD_LDFLAGS needs -L$(SPRO_VROOT)/lib as without it can't find
>> -lCrun as provided by mysql_config
>>
>> Thanks
>>
>> Amanda
>>
>> _______________________________________________
>>
>>
>> webstack-discuss mailing list
>> webstack-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
>
> _______________________________________________
>
>
> webstack-discuss mailing list
> webstack-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss