Jeff Trawick wrote: > Amanda Waite wrote: >> Hi again, >> >> I've made the changes Seema suggested and the updated webrev is at: >> http://cr.opensolaris.org/~tekgrrl/CR-6816914 >> >> I've used the same variables in the Makefile.sfw as Sriram did for >> PHP as it might pay to be consistent. I'm assuming that the >> dependencies in usr/src/cmd/Makefile are added in no particular order >> which seems strange giving how particular we are usually. > > Why was the runpath removed? > > -LIGHTTPD_LDFLAGS="-L$(MYSQL_LIB) -R$(MYSQL_LIB) $(LDFLAGS) -lsendfile" > +LIGHTTPD_LDFLAGS="-L$(SPRO_VROOT)/lib -L$(ROOT)$(MYSQL_LIBDIR) > -lsendfile" Because it's provided by mysql_config, the only time you need to override the flags provided by mysql_config is when you want to build from the libs in the workspace, then you have to add the link time flags (-L$(ROOT)...). All of the -R options are are set in the Lighttpd Makefiles created by the configure script. I've checked all of the RPATHS in *all* of the binaries as well as checking them all with ldd. They are all good.
Thanks Amanda > > >> Amanda Waite wrote: >>> Hi there, >>> >>> Could you kindly review the following update to Lighttpd: >>> >>> http://cr.opensolaris.org/~tekgrrl/CR-6816914/ >>> >>> Updating Lighttpd to use the MySQL 5.1 libraries also fixes 3 other >>> issues. Lighttpd no longer has a build time dependency on >>> /usr/sfw/bin/mysq_config and the Lighttpd package dependency is now >>> for the MySQL 5.1 library package and not the whole of MySQL. The >>> last fix was just a case of removing any reference to /usr/sfw/lib >>> as Lighttpd no longer needs it. >>> >>> LIGHTTPD_LDFLAGS needs -L$(SPRO_VROOT)/lib as without it can't find >>> -lCrun as provided by mysql_config >>> > What changed from 5.0 to 5.1 in that respect? It looks like that > information is getting copied to component after component. > > (And recalling the discussions about different locations of > SunStudio[Express] I hope that somehow apps have no problems finding > the C++ RTL.) > > _______________________________________________ > > > webstack-discuss mailing list > webstack-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
