On 09/09/08 16:43, Bjorn Munch wrote: > On 09/09 14.40, Sunanda Menon wrote: > >> Hi , >> >> Please review the code changes for 6693315: bump mysql from 5.0.45 to >> latest 5.0.* at >> http://cr.opensolaris.org/~sunandam/6693315/ and let me know your >> comments ASAP. >> > > I have a few comments: > > install-sfw and install-sfw-64: > > In the function fix_sed_path, why do you have a for loop over a list > with only one element? > > I also wonder about the name of that function, why "sed"? > > The function is called fix_sed_path as I'm using sed to change the internal path names being used in mysql_config.
> *.cnf.patch: > > Since these all do the same change, it may be better to concatenate > them into a single patch file, then use the more common command line > form "gpatch < my-cnf.patch". > Yeah ,I can try using one single patch but would prefer to keep it in the Makefile and do the patching before I build the source . > Alternatively, since the change is trivial, perhaps running a simple > sed command on each file would be better? It would be more obvious > from Makefile.sfw what you are changing. > > In fact, if you do that perhaps it could be moved out of > Makefile.sfw and into the install-sfw scripts. That is, if those > .cnf file are just copied during install, so you don't have to patch > them *before* doing the build. > > I'm not qualified to comment on the validity of that change from > 5.0.45 but I assume the MySQL people know what they're doing. :-) > > I also see you have replaced some "5.0.45" with just "5.0". I agree > with that change. :-) > > -- Sunanda Menon Database Technology Group BLR03, x87098/91-80-66937098 http://blogs.sun.com/smenon -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/webstack-discuss/attachments/20080910/94ba4215/attachment.html>
