Sunanda, Here are a few more comments from quick skip through ..
Paul Sunanda Menon wrote: > Updated WebRev's are posted at http://cr.opensolaris.org/~sunandam/6693315/ 1. usr/src/pkgdefs/SUNWmysql5test/prototype_com Do all these files (f ) need the 'write' permission bit set? 2. METADATA file Do you have a METADATA file for this package? If not, you should have one. If you do, doesn't the pkg version need updating? 3. usr/src/cmd/mysql-5-0/Makefile.sfw You might want to apply the following ... Roland Mainz wrote: > - Please use "env - ..." and not "env ..." in > the Makefiles to make sure "configure" & "make" > only see the env variables they should really get > (and not pick-up any random env variable) > - Please use either $(SHELL) or /usr/bin/bash for > "configure" calls (so we know which one is used and > "configure" doesn't pick one itself) Christopher Mi wrote: > Use the method define in Makefile.master > since you have a standard METADATA file. > > VER =$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) > TARBALL =$(VER).tar.bz2 4. usr/src/cmd/mysql-5-0/Solaris/mysql.xml Move the Copyright lines to after the "CDDL HEADER END" header. -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
