Siva,
looks fine.
-ps
Sivakumar Shanmugasundaram wrote:
> Prashant,
>
> I have fixed the shebang to /usr/ruby/1.8/bin/ruby now. Please review
> again. Thanks.
>
> Regards
> Siva
>
>
> Prashant Srinivasan wrote:
>> Siva,
>> lets use /usr/ruby/1.8/bin/ruby in the shebang line. Using
>> /usr/bin/env ruby is a good idea for user programs that don't need to
>> tie in to a specific version. But, since the packages that we're
>> delivering actually depend on ruby 1.8, it's good to make the shebang
>> as specific as possible.
>>
>> Looks fine apart from that.
>> -ps
>>
>> Sivakumar Shanmugasundaram wrote:
>>> Team!
>>>
>>> Resending it again, as I havent got any reviews, as possibly it was
>>> sent as a reply to an existing thread.
>>>
>>> Please review the webrev (same URL =
>>> http://cr.opensolaris.org/~ss39446/ruby-cr6635728) which contain fixes
>>> for both the problems mentioned in this CR (1. SUNWruby18u package
>>> dependencies and 2. Presence of /usr/local/bin/ruby as #!)
>>>
>>> Thanks
>>> Siva
>>>
>>>
>>>
>>> Sivakumar Shanmugasundaram wrote:
>>>
>>>> Jyri,
>>>>
>>>> I was wrong in my assumption. Looks like the 'ruby installer' hard
>>>> codes #!/usr/local/bin/ruby into some of the .rb files. That was
>>>> what the comment was referring to.
>>>>
>>>> I am pulling out this webrev. I will submit another one with the
>>>> fix for the /usr/local/bin/ruby issue as well.
>>>>
>>>> Apologies for the trouble and thanks for bringing this up.
>>>>
>>>> Regards
>>>> Siva
>>>>
>>>>
>>>> Jyri Virkki wrote:
>>>>
>>>>> Sivakumar Shanmugasundaram wrote:
>>>>>
>>>>>> Jyri,
>>>>>>
>>>>>> That is part of a feedback for another CR (code review submitted
>>>>>> by Chris Zhu), where the reviewer commented on the presence of
>>>>>> /usr/local/bin/ruby in the man.1 file.
>>>>>>
>>>>> So the /usr/local/* part is being fixed as part of another bug?
>>>>>
>>>>> Ok by me, but do add a comment in 6635728 saying so and add the other
>>>>> bug in the "see also" list. That way there's a trail to the other bug
>>>>> available.
>>>>>
>>>>>
>>>>>
>>> _______________________________________________
>>>
>>>
>>> webstack-discuss mailing list
>>> webstack-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
>>> _______________________________________________
>>>
>>>
>>> webstack-discuss mailing list
>>> webstack-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss
>>>
>>
