Sivakumar Shanmugasundaram wrote: > > Please review the webrev (same URL = > http://cr.opensolaris.org/~ss39446/ruby-cr6635728) which contain fixes > for both the problems mentioned in this CR (1. SUNWruby18u package > dependencies and 2. Presence of /usr/local/bin/ruby as #!)
Looks ok now. I should point out, though it's probably premature to do it right now but do think about it.. The _install (see usr/src/tools/install.subr) used by most sfw install scripts has a 'P' type for perl which sets the perl path. You could look into adding a similar type for ruby for the same purpose. That way all future ruby scripts could reuse it. That said, since there are no ruby scripts in the system outside of ruby integration itself, I'm not going to say it's urgent right now. If other components start using ruby scripts later it'll be good to generalize it. -- Jyri J. Virkki - jyri.virkki at sun.com - Sun Microsystems
