* install-mysql-64 script is re-doing what install-mysql does.
This should be avoided.
For example, both the scripts are creating links as below:
--------------------
# create the links to access /usr/mysql/5.0 from /usr/mysql
cd ${ROOT}/usr/mysql
_install L 5.0/bin bin
_install L 5.0/lib lib
_install L 5.0/man man
_install L 5.0/docs docs
_install L 5.0/include include
_install L 5.0/share share
_install L 5.0/sql-bench sql-bench
_install L 5.0/mysql-test mysql-test
cd ${ROOT}/var/mysql
_install L 5.0/data data
cd ${ROOT}/etc/mysql
_install L 5.0/my.cnf my.cnf
---------------------
Let install-mysql-64 handle only the 64-bit specific changes.
* In usr/src/pkgdefs/SUNWmysql5u/prototype_sparc ,
d none usr/mysql/5.0/lib/sparcv9 0755 root bin
is listed twice.
* Why do you need install32 and install_mysql32 targets ?
Instead, can't you define:
-----------------------
install: install_mysql32 install_mysql64
install_mysql32: build_mysql32
(cd $(MYSQL_DIR); \
env $(ENVLINE) $(MAKE) install)
ksh93 ./install-mysql
install_mysql64: build_mysql64
(cd $(MYSQL_DIR_64); \
env $(ENVLINE64) $(MAKE) install)
MACH64=$(MACH64) ksh93 ./install-mysql-64
-----------------------
-- Seema.
Sunanda Menon wrote:
> Hi ,
>
> I would like the changes to be reviewed at
> http://cr.opensolaris.org/~sunandam/6634053
> Please let me know your comments latest by Tuesday 11th March EOD.
>
> Thanks Sunanda
>
