Hi Seema ,
I have created the webrev again at
http://cr.opensolaris.org/~sunandam/6634053.Please review and also
please see inline .
Thanks Sunanda
Sunanda Menon wrote:
> Hi Seema ,
>
> Please see inline .
>
> Thanks Sunanda
>
> Seema Alevoor wrote:
>
>> usr/src/cmd/mysql-5-0/Makefile.sfw :
>> - just curious, why is the below line needed ?
>> find . -name core -exec rm -f {} \;
>>
> This is from a previous putback in the gate and I have retained it .Can
> verify if we really need this .
>
>
>
The earlier mysql 4.0 and the mysql5.0.4 have the line for removal of
core and hence this has been retained for mysql32 bit target as well .
I see a core getting generated at under mysql-5.0.45/dbug and this line
removes that for 32 bit compilation .
I don't intend to change this with this putback hence retained as is .
>> - build targets are "build_mysql32" and "build_mysql64" but install
>> and clean targets are "install32", "install64" and "clean32", "clean64".
>> To be consistent, you can change build targets as build32 and
>> build64.
>>
>
> I can change this ...
>
The target has been renamed as build32 and build64 respectively .
>> usr/src/cmd/mysql-5-0/install-mysql-64 :
>> - install_dir function is not used anywhere in the script.
>>
>> - In the comments, change the script name to "install-mysql-64"
>>
>
> I would like to keep the definition as it is .Though the script does not
> call it but it just defines the install_dir function that can be used
> later if required .
>
This definition as mentioned earlier has been retained .
