On Tue, Mar 11, 2008 at 01:15:03PM +0100, Victor Kirkebo wrote: > http://cr.opensolaris.org/~vk136562/memcached-1.2.5/
Mike recently putback fixes for 6657798. You need to follow the direction he set there. In particular, you've unapplied some of his changes in existing makefiles. When is pod2man used? And why are you supplying your own instead of using the one on the system? For files that are passed through the C compiler, "#pragma ident" and "#ident" tell the compiler to put bits in the binary's comment section. The ident strings in all other files are nothing more than comments, and should look like all the rest of the comments in the file. That is, no "pragma" and follow the usual whitespace convention of "# ident". Also make sure that the ident lines are correctly unexpanded and are using the right %-expandos and whitespace. Correct examples can always be found in /ws/onnv-gate/usr/src/prototypes. usr/src/lib/memcached/Solaris/memcached looks a little fishy. memcached-java has no build process? You're just unpacking the archive to find the configure script, but then not running it? Solaris/memcached is just moving, so you don't need to update its copyright. There are a couple of other files you've done nothing except update the copyright, too. I didn't review memcached before; is there a reason you're carrying around a copy of the memcached man page, rather than modifying the existing one with a sed script the way most of the rest of the components do? You still have the sed script, and it looks like it's still invoked in your install script ... so does it add all the extra Sun stuff a second time? In memcached/install-sfw, you're copying the rbac (not smf, btw) files into place, even though you don't completely own them. Mike, is this okay with you? It seems like this should be done in a more common location. In memcached/install-sfw-64, you set MANSCRIPT, even though you're not installing any manpages. SUNWlibmemcached/depend: this is identical to the common depend file; you should use that one (via DATAFILES in Makefile) instead. SUNWmemcached-java/depend: same comment, though shouldn't you have a dependency on one of the java packages (SUNWj6rt or something)? SUNWmemcached/depend: shouldn't this now depend on SUNWlibmemcached? Danek
