Norm Jacobs wrote: > Victor Kirkebo wrote: >> Please see my comments inline. >> Norm Jacobs wrote: >> >>> As your RTI advocate, I normally do a code review anyway, but you >>> should not rely on that for your code review. If you use me as a >>> code reviewer, you will need to use another advocate for your RTI. >>> At any rate, here are my comments from a quick pass through your >>> webrev: >>> >>> usr/src/lib/Makefile: >>> >>> * are there dependency relationships between libmemcached, >>> memcached, and memcache-java that need to be expressed here? >>> >> No. The server (memcached) and the clients (libmemcached and >> memcache-java) can be installed on separate systems. >> > The dependencies I was referring to here are build dependencies. For > example, do you need to build libmemcached first so that memcached > and/or memcache-java can link against it? If so, you will need to > identify this in the Makefile with something like: > > memcached: libmemcached > Otherwise builds may accidentally work some or most of the time, but > appear to fail almost randomly. > > Runtime dependencies may be declared in the resulting executables and > shared objects, but should also be reflected in the packaging in the > depend files. I didn't pay that close attention to your package depend > files on my initial pass through, but it's worth taking a look at. I answered in haste. But the answer is nevertheless that there are no dependencies that need to be expressed in the Makefile or in the package depend file. > > -Norm > > PS. > Do you have a pointer to a new webrev? http://cr.opensolaris.org/~vk136562/memcached-1.2.5/ I uploaded the new webrev to the same location as the old one. I probably should've created a brand new one...
-Victor
