On Fri, Feb 08, 2008 at 11:36:58AM +0530, rahul wrote: > Hi, > I have attached below, the diffs for adding mod_dtrace to apache, > it also includes refactoring of the Makefile.sfw so that it is easier to > add newer modules. I would like to get it reviewd, please do help. > > http://cr.opensolaris.org/~vrthra/6644707.dtrace/ > Quick comments (will try to do more detail / testing later):
There's a bunch of files that probably shouldn't have been in the diff for mod_dtrace: usr/src/cmd/apache2/modules/apxs-jk usr/src/cmd/apache2/modules/fcgid.mk usr/src/cmd/apache2/modules/jk.mk usr/src/cmd/apache2/modules/security2.mk usr/src/pkgdefs/SUNWapch22m-jk/Makefile usr/src/pkgdefs/SUNWapch22m-jk/copyright usr/src/pkgdefs/SUNWapch22m-jk/depend usr/src/pkgdefs/SUNWapch22m-jk/pkginfo.tmpl usr/src/pkgdefs/SUNWapch22m-jk/prototype_com usr/src/pkgdefs/SUNWapch22m-jk/prototype_i386 usr/src/pkgdefs/SUNWapch22m-jk/prototype_sparc And usr/src/cmd/apache2/modules/Makefile.sfw contains a bunch of changes related to the other two modules. As for usr/src/cmd/apache2/modules/apxs-dtrace, I really don't like it. First of all, apxs has a long established function in httpd context, so using the same name for something else seems very wrong to me. I'd be very much in favor of using a Makefile instead which then calls regular apxs - just like it was intended. vh Mads Toftum -- http://soulfood.dk
