[Mads Toftum:]
| > Hi,
| > I have attached below, the diffs for adding mod_dtrace to apache,
| > it also includes refactoring of the Makefile.sfw so that it is easier to
| > add newer modules. I would like to get it reviewd, please do help.
| >
| > http://cr.opensolaris.org/~vrthra/6644707.dtrace/
| >
| Quick comments (will try to do more detail / testing later):
|
| There's a bunch of files that probably shouldn't have been in the diff
| for mod_dtrace:
|
| usr/src/cmd/apache2/modules/apxs-jk
| usr/src/cmd/apache2/modules/fcgid.mk
| usr/src/cmd/apache2/modules/jk.mk
| usr/src/cmd/apache2/modules/security2.mk
These should be in, as it is a refactoring of the earlier Makefile.sfw
The refactoring is just a textual split of the earlier large
Makefile.sfw
| usr/src/pkgdefs/SUNWapch22m-jk/Makefile
| usr/src/pkgdefs/SUNWapch22m-jk/copyright
| usr/src/pkgdefs/SUNWapch22m-jk/depend
| usr/src/pkgdefs/SUNWapch22m-jk/pkginfo.tmpl
| usr/src/pkgdefs/SUNWapch22m-jk/prototype_com
| usr/src/pkgdefs/SUNWapch22m-jk/prototype_i386
| usr/src/pkgdefs/SUNWapch22m-jk/prototype_sparc
I will remove these, (seems like I touched them by mistake, with out
modifying the content.)
| And usr/src/cmd/apache2/modules/Makefile.sfw contains a bunch of changes
| related to the other two modules.
As mentioned above, it is a refactoring of Makefile.sfw to make it
easier to add newer modules (It is necessary as more modules are waiting
in the pipeline.) The refactoring does not change the targets of these
earlier modules, rather, splits them into their own files.
| As for usr/src/cmd/apache2/modules/apxs-dtrace, I really don't like it.
| First of all, apxs has a long established function in httpd context, so
| using the same name for something else seems very wrong to me. I'd be
| very much in favor of using a Makefile instead which then calls regular
| apxs - just like it was intended.
Actually, if you look at the apxs-xxx, it tries to use apxs for each of
the modules. the dtrace is the only exception in this case in that it
does not use apxs directly. However it also uses apxs to query the
apache compilation flags inorder to compile it.
The shellscripts are named apxs-xxxx for this reason, that they are a
wrapper over apxs.
rahul
--
1. e4 _
