Hi Chris, thanks. comments inlined. -> I don't see the depend file from SUNWruby18u show up in the code review, so that's probably still pointing to 1.8.6 p110 and needs changing. -> pkginfo.tmpl needs changing per Amanda's comment -> I'm curious about why you reordered the application of the patches(Not that it matters functionality wise.) -> Thanks for removing the unnecessary "cd ../.."s from the patching code. -> Why is there a line inserted into the man page? -> I logged into your machine, and you've upgraded the machine to use your test ruby 1.8.6 p287 packages. Not a good idea, since Adam and I are also using the machine to for Ruby work. Create a whole root zone to test your packages. -> It seems like you started from p110 rather than the p230 integration - It's a good idea to run a nightly sooner rather than later to make sure all the added files into the prototype have been included in the packages.
-ps Chris Zhu wrote: > Hi all, > > Please help to review the CR6721879 > <http://monaco.sfbay.sun.com/detail.jsp?cr=6721879> Ruby patch level update > to p287. > > And the webrev is ready on > http://cr.opensolaris.org/~chriszhu/CR6721879-webrev/ > > > Thanks > Chris > ------------------------------------------------------------------------ > > _______________________________________________ > > > webstack-discuss mailing list > webstack-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/webstack-discuss > -- Prashant Srinivasan F/OSS Enthusiast Sun Microsystems, Inc. http://blogs.sun.com/prashant GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x82FBDE5A
