Prashant Srinivasan wrote: > Hi Chris, thanks. comments inlined. > > -> I don't see the depend file from SUNWruby18u show up in the code > review, so that's probably still pointing to 1.8.6 p110 and needs > changing. I have update depend of SUNWruby18u, just for the name of SUNWruby18r. > -> pkginfo.tmpl needs changing per Amanda's comment Done for both SUNWruby18r and SUNWruby18u. > -> I'm curious about why you reordered the application of the > patches(Not that it matters functionality wise.) I reordered the patch sequence of ruby-sparc-perf.patch and ruby-dtrace-1.8.6.patch, as ruby-dtrace-1.8.6.patch is only for x86, so the source code will be different in x86 and sparc after patching ruby-dtrace-1.8.6.patch, although gpatch can find the right place to patch the following patches, I prefer to putting it as the last patch which will make the code clear in the new ruby patch version. > -> Thanks for removing the unnecessary "cd ../.."s from the patching > code. > -> Why is there a line inserted into the man page? No, it's just an update of the patch line info. > -> I logged into your machine, and you've upgraded the machine to use > your test ruby 1.8.6 p287 packages. Not a good idea, since Adam and I > are also using the machine to for Ruby work. Create a whole root zone > to test your packages. Sorry for it. I will take care. > -> It seems like you started from p110 rather than the p230 > integration - It's a good idea to run a nightly sooner rather than > later to make sure all the added files into the prototype have been > included in the packages. Yes, the nightly have completed successfully.
Chris > > -ps > > Chris Zhu wrote: >> Hi all, >> >> Please help to review the CR6721879 >> <http://monaco.sfbay.sun.com/detail.jsp?cr=6721879> Ruby patch level >> update to p287. >> >> And the webrev is ready on >> http://cr.opensolaris.org/~chriszhu/CR6721879-webrev/ >> >> >> Thanks >> Chris >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> >> >> webstack-discuss mailing list >> webstack-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss >> > >
