Matt Ingenthron wrote: > Trond Norbye wrote: >> See: >> >> http://cr.opensolaris.org/~trond/webrev/ > > From the peanut gallery.... > > It generally looks good. I like the change to the default user of > noaccess. > > Having said that, I'd highly recommend adding some default options, > say "-L -m 64". Why? On popular Linux distros they ship with default > 64MB configurations via init scripts. I've seen references from Ruby > on Rails people which seem to indicate they think that's the default > as a result (even though memcached has no default). That's not really true.. 64MB is the default maxbytes if you don't provide a -m setting. That being said I believe that it is impossible to "auto-tune" this setting, because you don't know if the user will be using the machine as a dedicated memcached server or just share some of the spare memory in the box. I believe that the end user _has_ to manually set this option for the instance so any default is as good as the other...
> > Or looking at it from another angle, just being able to do an "svcadm > enable memcached" after installing the package should yield something > useful, even if it's not perfect for anyones usage. > You can do that now... > Might it be better for the -u flag and the -m flag to just be in the > default service manifest? As it is now, one would have to edit the > script the service is execing to change the user and there isn't a > sane default. No, if you just edit the smf configuration and adds the options it will automatically work: example% svccfg svc:> select memcached svc:/application/database/memcached> setprop memcached/options=("-u" "myuser" "-m" "1024") svc:/application/database/memcached> quit example% svcadm refresh memcached This will cause memcached to be started as: memcached -u noaccess -u myuser -m 1024 The "-u noaccess" will be overridden by the "-u myuser" resulting in that the service will run as myuser instead of noaccess. The current patch will allow you to install memcached and enable it without touching anything. That will result in running as noaccess with 64MB and 4 threads. Cheers, Trond