No. I think that's the wrong solution (in fact it's not a solution, it's a cover up).
Your directory & makefile structure is not right given that you want to include the libpqxx files in the existing postgres packages. You should be building libpqxx *in* the postgres/postgresql-8.x Makefile (refer to my completed code review email that I'm just about to send you). Bjorn Munch wrote: > On 07/05 16.39, Bjorn Munch wrote: > >>I have prepared a webrev: >> >>http://cr.opensolaris.org/~bjornmu/pqxx-webrev/ > > > I have a comment on my own. :-) > > A side effect of adding this into the existing PostgreSQL packages > shows itself when I build PG manually: > > The protofix command executed at install in the Makefile gives lots of > warnings because the files built by libpqxx haven't been installed > yet. The make isn't flagged as failed so nightly isn't affected, but > it's irritating when building manually (which I expect I and others > will need to do many times in the future :-) > > So, I would probably want to add a grep -v or something to filter this > out from the cmd/postgres/postgres-8.3/Makefile.sfw. > > - Bjorn > _______________________________________________ > databases-discuss mailing list > databases-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/databases-discuss
