On 16/05 15.29, James Gates wrote: > 1) usr/src/cmd/postgres/postgresql-8.3/Makefile.sfw > > a) What's the point of the "noxx-install:" target? If you accept the > fact that building libpqxx is now an integral, essential, mandatory & > dependent part of building postgres (as emphasized by the proto-fix > errors), then the target is pointless. If libpqxx must be built for the > package(s) to be successfuly created, then why build postgres without it?
There is no need for this target in connection with building the Solaris packages. I added it to make it easier to build tarballs for upload to postgresql.org *without* libpqxx from the same Makefile. In this case, the package definitions aren't relevant. OTOH, since some changes have to be made to Makefile.sfw for these builds anyway (changing the install path), one could always put in this additional target as well, removing it from the "official" version. > b) You repeat dependencies in these 2 targets: > > install: install32 install64 installxx > installxx: install32 install64 [......] > Again, if you accept that libpqxx is now an integral part of building > postgres, then the following is better: > > install: installxx > installxx: install32 install64 Agree, that is better even though my first version is sort-of more "logical" since it lists the installs that the full install consists of. > 2) /usr/postgres/8.3/lib/libpqxx-2.6.9.so (32bit and 64bit) > > If I run ldd on this library in your proto area, it fails to satisfy the > dependency on libpq.so.5: > > $ ldd libpqxx-2.6.9.so > libpq.so.5 => (file not found) > libCstd.so.1 => /usr/lib/libCstd.so.1 > libCrun.so.1 => /usr/lib/libCrun.so.1 > libc.so.1 => /lib/libc.so.1 > /usr/lib/cpu/sparcv8plus/libCstd_isa.so.1 > libm.so.2 => /lib/libm.so.2 > /platform/SUNW,Sun-Fire-480R/lib/libc_psr.so.1 > > This is because the RUNPATH does not include /usr/postgres/8.3/lib when > it's built: Ouch! [...........] > I think you need to tweak the LD_OPTIONS in > usr/src/cmd/postgres/postgresql-8.3/libpqxx/Makefile.sfw I will investigate. I also need to find out why my test script didn't fail. - Bjorn
