sunanda menon wrote: > Jeff Trawick wrote: >> sunanda menon wrote: >>> Hi, >>> >>> We have replaced the mysql-5.1.37 tarball with that of patching the >>> mysql-5.1.37.tar.gz source from the download site. >>> Please review the changes made at >>> http://cr.opensolaris.org/~sunandam/6857014/ and let me know your >>> comments. >>> >>> Thanks Sunanda >>> >>> >> >> >> Is there a separate CR covering the cflags change from -x04 to -x02? >> That should be called out in the webrev. >> >> -CXXCOMMONFLAGS= -DDBUG_OFF -DBIG_TABLES -DHAVE_RWLOCK_T -KPIC -DPIC >> -xO4 \ >> +CXXCOMMONFLAGS= -DDBUG_OFF -DBIG_TABLES -DHAVE_RWLOCK_T -KPIC -DPIC >> -xO2 \ >> -xprefetch=auto -xprefetch_level=3 -mt -fns=no -fsimple=1 >> -xbuiltin=%all \ >> -xlibmil -xlibmopt -norunpath >> >> @@ -56,7 +56,7 @@ >> CXX32FLAGS= $(CXXCOMMONFLAGS) >> >> # C common compiler flags >> -COMMONCFLAGS= -xO4 -xstrconst -xprefetch=auto -xprefetch_level=3 -mt\ >> +COMMONCFLAGS= -xO2 -xstrconst -xprefetch=auto -xprefetch_level=3 -mt\ >> >> >> That's the only thing I'm concerned about, but I guess finding/fixing >> that issue can be prioritized/resourced independently from getting >> the current failures resolved. >> >> +1 from me if the issue of -x02 can be clarified: > > I'll have to do this as a possible workaround for now as the issue has > been taken up at http://bugs.mysql.com/bug.php?id=49091. > -xO2 is a tried and tested optimization flag used by the mysql > community and also in the mysql.com version sources.
No disagreement here on -x02 and that separate tracking of the optimization issue. What procedural steps associated with this particular check-in will track the fact that the optimization was changed for a separate reason from the upgrade and DTrace support refactoring? > > Hope this clarifies. > > Thanks Sunanda > > > >> >> * note the related CR with the webrev >> ** should be clear that lowering the optimization for the entire >> package is a work-around >> ** a CR should be kept open to investigate/resolve the underlying >> problem in some manner other than lowering the optimization for the >> entire package
