On 16/12/2009 11:53, sunanda menon wrote: > >>>> >>>> usr/src/cmd/mysql-5-1/Makefile.sfw >>>> >>>> - Why all of the touching of files and the sleep statements? It's >>>> hard to see what this achieves aside from adding 20-odd seconds to >>>> the build time. >>> >>> >>> Since we are patching the mysql-5.1.37 source base ,some files gets >>> modified like the Makefile.am,configure.in and other input files >>> which causes an automatic rerun of the GNU autotools and which >>> caused the nightly builds to fail with messages such as posted >>> earlier in this forum >>> >>> ==== Build errors (non-DEBUG) ==== >>> >>> aclocal.m4:14: error: this file was generated for autoconf 2.61. >>> aclocal.m4:14: error: this file was generated for autoconf 2.61. >>> >>> >>> ==== Elapsed build time (non-DEBUG) ==== >>> >>> By doing these changes,we are just avoiding retrigger runs of GNU >>> autotools. >> >> And why the 'sleep 5's? that was my biggest concern, if you need to >> sleep to make it all work then why? Is there some issue with parallel >> make? Did you hit some kind of race condition? Sleeps are never a >> good way to avoid that kind of issue. >> >> Amanda >>> > It's just a simple and safe bet to do it such that when I do a touch > a; touch b would always make a older than b and I don't see any > problem in keeping it either.What would you suggest? > I don't have any suggestions at the moment, I'd have to understand the entire scenario. I can't see how sleeping in order to ensure something happens is ever a good idea. If others feel it's ok to do what you are doing here then you can consider that I've reviewed the changes and I'm ok with them.
Amanda
