Hi,
It would not be only a rename. I really want to deprecate
compareToExpected and finally to remove it, not to alias it:
compatibility can't be preserved together with fixing the weak points of
compareToExpected.
I have mostly prepared the changes so you don't need to look at it. I
find your diff modes idea interesting and this could be added later to
verifyContent.
Marc.
Paul King wrote:
I have no problem with a rename, verifyContent seems a good choice.
I have no problem with improved error reporting etc. as long as
the underlying functionality is backwards compatible (i.e. if we
add an alias compareToExpected->verifyContent that existing tests
should work without change - at least for one release, e.g. 2.1,
or we keep the old one around at least for one release).
I am happy to look at bits of this if you want. I had hoped
to make a pluggable diff handler that would allow us to use
different diff mechanisms under the covers, e.g. binary diff,
text diff (current) and XmlUnit. If you can think how that
would fit into what you planned, the would be good. I was
thinking of adding just an attribute diff="auto|xml|text|binary"
with auto being the default where it would try to pick the
handler based on the content type.
Cheers, Paul.
Marc Guillemot wrote:
Hi,
I've several problems with current compareToExpected step:
- name doesn't fit with all our verifyXXX steps
- if reference file doesn't exist, it looks silently for it in a
subfolder named "expected"
- it doesn't fail if reference file doesn't exist at all but just
creates it
- it doesn't fail if an IO error occurs
Therefore I propose to deprecate compareToExpected and to introduce a
verifyContent which would offer the same functionalities as
compareToExpected but in a more deterministic way. This would look like:
<verifyContent referenceFile="someFile.xxx".../>
Any thoughts?
Marc.
_______________________________________________
WebTest mailing list
[email protected]
http://lists.canoo.com/mailman/listinfo/webtest
_______________________________________________
WebTest mailing list
[email protected]
http://lists.canoo.com/mailman/listinfo/webtest
_______________________________________________
WebTest mailing list
[email protected]
http://lists.canoo.com/mailman/listinfo/webtest
