Chuck Esterbrook <[EMAIL PROTECTED]> wrote:
> At 01:54 PM 5/29/2001 -0500, Ian Bicking wrote:
> >If you have an auxiliary directory, how about putting CAdapter in it?
> >It really is a lot faster than the Python version, and easier to
> >install than mod_python|snake. I've used it happily for quite a while
> >now.
>
> The only question I have at this point is a concern about maintaining the C
> Adapter. For example, at first glance it doesn't appear to have retry
> feature that the other adapters have.
>
> mod_webkit is also based on C and I'm wondering if these two guys,
> mod_webkit and "C CGI Adapter" should share some C library code. For
> example, mod_webkit already has the retry feature.
Well, retry is just a code structure issue, not something that could
fit in a library. It could be added easily enough.
The whole thing is just 248 lines, there's not a lot there to share
anyway. The most useful might be the marshalling. mod_webkit uses
Python's marshalling functions, I think. I just recreated the small
portion needed to send the request, with about 40 lines. The other
portion might be reading and parsing address.text, and opening the
connection to it. That's 25 lines of C. Not really worthy of reuse.
I could add the retry, but just haven't. I would actually prefer to
add something that restarted the AppServer upon failure or timeout, as
I feel this solves the problem much more robustly than retrying does.
I don't think it should be too hard to maintain, really. All the
adapters are well partitioned from the rest of Webware. As long as
Webware continues to take input over the socket in the same format,
the adapter won't need any updating.
The one big problem is that it doesn't have any configurability,
except to recompile it. Right now there's nothing to configure except
the location of address.text, which is just as easily configured with
a symbolic link. If there were timeouts and such, those would need
configurability, though maybe recompiling would be fine too.
Ian
_______________________________________________
Webware-devel mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/webware-devel
