On Saturday, November 12, 2016 at 9:34:46 PM UTC-5, Tom Keffer wrote: > > Not sure what sort of feedback you're looking for. I assume this is a > work-in-progress? >
my intent is to replace Standard with something more modern, more functional (wrt sensors and out-of-box experience), and with less copy/paste throughout. so any feedback is appreciated, from look-and-feel to implementation. it would be nice to know how long newskin Standard takes to generate compared to master Standard, on various hardware. > Why the decision to break out some of the labels, (e.g. > $Extras.Labels.celestial_title) but not all of them? > > Why the decision to use $Extras.show_extraTemp1 instead of just > autodetecting ? If we want a user to manually toggle whether extra sensors > are shown, we should probably create a special tag such as > $showSensor.extraTemp1. > this part is definitely in progress. labels: translation is a pain, mostly because one must hunt and peck through each file to find the strings that must be translated. the use of $obs.label.* is an attempt to do it all using the labels specified in skin.conf, especially for self-contained parts such as the hilo include. however, while that makes sense for observations, it might not make sense for thinks like the celestial stuff. that would require a different pattern, such as putting the labels in Extras. conditional inclusion: the skin should require no configuration, so it should autodetect data/sensors. however, there are cases where we know some people do not want to display certain data. inside temp/hum is one example. hopefully neither of these will be an obstacle to the primary goal of a Standard refresh. m
