Thanks, Gary! This is admittedly minor, since wee_import clearly (and accurately!) reports what it’s doing. But cleaning up the docs should save others from some head scratching.
-Les > On 24 Feb 2021, at 22:22, gjr80 <[email protected]> wrote: > > Thanks Les, QC is obviously lacking at weewx.com <http://weewx.com/> at the > moment. > > I have revised the relevant stanzas in the wee_import section of the > Utilities Guide and added a brief explanatory note as you suggest. Have also > reworked the weeimport.py comments. Issue 652 > <https://github.com/weewx/weewx/issues/652> and commits 402db1f > <https://github.com/weewx/weewx/commit/26f25945f231a01b80dbd102ae9b55669d2dc9ea> > and 26f2594 > <https://github.com/weewx/weewx/commit/26f25945f231a01b80dbd102ae9b55669d2dc9ea> > refer. Long story but at the moment those changes will only be visible come > the next release, in the meantime I will get relevant changes made to the > on-line documentation over the next day or so. > > Gary > On Thursday, 25 February 2021 at 06:47:40 UTC+10 ln77 wrote: > The documentation for wee_import says that the --from and --to date/times are > inclusive and exclusive, respectively. But what is reported when an import > is run, and what the code actually implements, is the other way around: the > --from is exclusive and the --to is inclusive. (To further the confusion, the > comment at line 187 in weeimport.py implies that both are inclusive.) The > way it is implemented makes sense given that the timestamp points to the end > of the archive interval, but the disparity is confusing. Assuming I’m > understanding this correctly, I’d suggest the utilities guide be corrected, > perhaps including a brief explanation of why exclusive/inclusive is the > appropriate choice. > > That said, I’m very happy to find that wee_import does exactly what I need to > recover a bunch of data. Saved me several hours of work! > > -Les > > > -- > You received this message because you are subscribed to the Google Groups > "weewx-user" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/weewx-user/831d2e68-6f2e-4e81-ad8d-5cfae7adb72an%40googlegroups.com > > <https://groups.google.com/d/msgid/weewx-user/831d2e68-6f2e-4e81-ad8d-5cfae7adb72an%40googlegroups.com?utm_medium=email&utm_source=footer>. -- You received this message because you are subscribed to the Google Groups "weewx-user" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/weewx-user/FCF06810-B4BE-4447-BAB2-4085DECDE2A6%402pi.org.
