[
https://issues.jboss.org/browse/WELD-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569204#comment-12569204
]
Martin Gencur commented on WELD-711:
------------------------------------
After recent tests I made I have to say that this fix (WELD-711) doesn't affect
performance (or at least I couldn't have found any differences). On the other
hand I found out that commit=362b515c93 (Minor refactor and fix test to be more
robust ) caused all the performance decline. I ran stress test on weld/master
with head=d40606dab and it was just good:
https://hudson.qa.jboss.com/hudson/job/perf-weld-numberguess-stress-single/142/artifact/report/log.txt,
then I ran the test with head=362b515c and the performance really went down:
https://hudson.qa.jboss.com/hudson/job/perf-weld-numberguess-stress-single/138/artifact/report/log.txt.
(nevertheless, I'd had to run a few more tests before I found out where the
bottleneck was). As the last thing I tried to run your branch, Pete, removing
the 362b515c and also WELD-549 (because removing just the former one resulted
in some conflicts) and the results are very good:
https://hudson.qa.jboss.com/hudson/job/perf-weld-numberguess-str!
ess-single/143/artifact/report/log.txt
> Calling Contextual.destroy on an instance still references an instance on
> BeanManager
> -------------------------------------------------------------------------------------
>
> Key: WELD-711
> URL: https://issues.jboss.org/browse/WELD-711
> Project: Weld
> Issue Type: Bug
> Components: Scopes & Contexts
> Affects Versions: 1.0.1.Final, 1.1.0.Beta1
> Reporter: George Gastaldi
> Assignee: Martin Gencur
> Priority: Minor
> Labels: AnnotationLiteral, MemoryLeak
> Fix For: 1.1.0.CR1
>
> Attachments: report.txt
>
>
> Using the seam-faces module @ViewScoped extension, when the object is
> destroyed by Contextual.destroy, weld still references an instance, avoiding
> being garbage-collected.
> Pseudo Code:
> Contextual contextual = ...
> Object instance = ...
> CreationalContext creational = ...
> contextual.destroy(instance, creational);
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
weld-issues mailing list
[email protected]
https://lists.jboss.org/mailman/listinfo/weld-issues
