Hi Andreas!
On 27.01.2008 13:35, Andreas Schneider wrote:
>
> Smaller patches than one big file would be nice.
>
Ok. I'll do that with the next patches (most probably after the tests
with Thomas revision 13255).
>> Additional notes on my patchset:
>>
>> - libs/3rdparty/qt4/CMakeLists.txt
>>
>> Since a version of Qt 4.x the DLLs of the lib are now ending with a "4".
>> I have changed that accordingly.
>
> Are you sure that this is the case for all released Qt version. Maybe the
> others should stay in the code. I think if the file doesn't exist, it would
> stop to work.
No. I am not sure when this was changed. I see three options:
- Find out in which version this was changed and let the CMake handle
this two versions
- Some kind of "if-file-exists" in the CMake-File...
- Depend the project on Qt 4.3.3 (starting with revision > 13255)
What do you think?
>> - libs/owutil/util/CMakeLists.txt
>> - libs/webcam/CMakeLists.txt
>> - wifo/phapi-util/CMakeLists.txt
>>
>> The lib files of these projects are not created without these definitions.
>
> I think this should be wrapped in an
>
> if (WIN32)
> endif (WIN32)
Ok.
>> - owbuild/owbuild/OWCreateProjectBinary.cmake
>>
>> This was tricky and I am still not absolutly sure about it. This patch
>> now enables the post-build-copy-process to copy the DLL and PDB files
>> from the correct directory (by taking the right buildtype (debug vs.
>> release) into account). Maybe someone can take a special look at this
>> one. Thanks!
>
> Yes, the files should be copied to the build type directory (release, debug)
Fine.
>> - wengophone/src/buildid/CMakeLists.txt
>>
>> The Preprocessor Definition "DD_BUILDID" had two "LL" at the end (I
>> don't know why) but they should be an integer. The patch fixes that.
>>
>
> #define FOO 42LL means that FOO is a long long.
>
> Current date and time is for example 20070127132638, this doesn't fit into an
> integer you need a 64bit variable. That's why the function in
> wengophone/src/WengoPhoneBuildId.cpp returns a long long.
>
> const unsigned long long WengoPhoneBuildId::getBuildId() {
> return DD_BUILDID;
> }
>
> So #define DD_BUILDID 2007012713263LL is right!
Hmm... Strange. I've just recompiled owbuildid. Now it seems to work
with these "LL" at the end (with an warning though).
But thanks for clearifing this issue.
I have still one more questions:
At the beginning of build process I get:
------ Rebuild All started: Project: owbuildid, Configuration: Debug Win32
------
Deleting intermediate and output files for project 'owbuildid', configuration
'Debug|Win32'
Building Custom Rule C:/Projects/wp-2.2/wengophone/src/buildid/CMakeLists.txt
Subversion (svn) command line not found, it is recommended to install it
-- OS: Windows-5.0
-- Processor: x86
-- Compiler: C:/Program Files/Microsoft Visual Studio 8/VC/bin/cl.exe
-- Build type: Debug
-- Build tool: C:/PROGRA~1/MICROS~3/Common7/IDE/VCExpress.exe
-- Build directory: C:/Projects/wp-2.2/build/debug
-- svn revision: 13253
-- Time:
[snip]
I believe the date-time used by the BUILDID comes from the time field
which - in my case - is empty. What do I have to do get that value?
It seems that "OWGetCurrentDateTime.cmake" respectivly a output in
"getcurrentdatetime.cpp" but I fail to decode what's going on in
there. (Looks like the cpp is compiled and run out of the
cmake-build-process; does that work under Windows?)
(Just for reference: I always had the svn revision 0 until I installed
the command-line version of subversion. After that the svn revision
was detected correctly.)
>> - wifo/owsl/src/core/owsl_address.c
>>
>> OWSL_FUNC_DEF (which is definded as __declspec(dllimport)) is already
>> set in the header. No need to do that again.
>>
>> - wifo/phapi/CMakeLists.txt
>>
>> There two patches in here...
>>
>> 1. The lib file is not created without this definition.
>
> Should be wrapped into if (WIN32)
>
Ok.
>> 2. The Visual C++ compiler option "-D" do strip the quotes on the
>> command line[2] so this must be handled by a define in "phapi.c".
>
> That's bad, have you tried to escape them? There should be another way to do
> that.
>
> -DWENGOPHONE_UA="\"wengo/v1/wengophoneng/wengo/rev${SVN_REVISION}/trunk/\""
>
> or
>
> -DWENGOPHONE_UA='"wengo/v1/wengophoneng/wengo/rev${SVN_REVISION}/trunk/"'
>
> or
>
> -DWENGOPHONE_UA="'wengo/v1/wengophoneng/wengo/rev${SVN_REVISION}/trunk/'"
>
Yeah, I also do not like this solution. I've tried your suggestions
and a lot of other things but I was not able to get around it. Any
Visual C++-Crack who knows how to fix that?
>> - wifo/phapi/phapi.c
>>
>> This is the second part of the "-D"-compiler-option problem of Visual
>> C++. I was not able to get the SVN-Revision into it so it's set to "0".
>> If somebody knows how to fix that (and knows how to include the svn
>> command line in the build process) please let me / us know. Thanks!
>>
>
> See above
Yes. I seems I need help by someone who knows what to do... Google
also did not bring up any workarounds.
>> - wifo/phapi/test/client/wlm_password.h
>>
>> Altough I think this is just a test-project and not critical for
>> wengophone I tried to fix this. I am again not sure about this one but
>> there seems to be a conflict with "unistd.h" and "stdio.h". This patch
>> fixes the problem.
>>
>> I hope this description was helpful for someone and somebody read so far
>> to read this ;).
>>
>
> Yes, thanks for the patch.
>
Thanks for reading and commenting!
>> I really would like to contribute to the project and would like to
>> update the wiki and/or get access to SVN-Repository to do some commits.
>> If anybody is able and willing to guide me through this process please
>> let me know. Thank you!
>>
>
> Currently the project is in an unmaintained state. Wengo stopped the
> development and someone is needed to maintain the project.
>
> I could commit your changes if you would correct them. I will test them after
> you did it.
I'll take Thomas' latest revision and work on that one. After that I
will come back and let the patches be reviewed again...
Greetings,
- Darsha
_______________________________________________
Wengophone-devel mailing list
[email protected]
http://dev.openwengo.com/mailman/listinfo/wengophone-devel
