Darshaka Pathirana wrote: > Hi Andreas! > Hi Darshaka,
>>> - wengophone/src/buildid/CMakeLists.txt
>>>
>>> The Preprocessor Definition "DD_BUILDID" had two "LL" at the end (I
>>> don't know why) but they should be an integer. The patch fixes that.
>>>
>> #define FOO 42LL means that FOO is a long long.
>>
>> Current date and time is for example 20070127132638, this doesn't fit into an
>> integer you need a 64bit variable. That's why the function in
>> wengophone/src/WengoPhoneBuildId.cpp returns a long long.
>>
>> const unsigned long long WengoPhoneBuildId::getBuildId() {
>> return DD_BUILDID;
>> }
>>
>> So #define DD_BUILDID 2007012713263LL is right!
>
> Hmm... Strange. I've just recompiled owbuildid. Now it seems to work
> with these "LL" at the end (with an warning though).
> But thanks for clearifing this issue.
>
> I have still one more questions:
> At the beginning of build process I get:
>
> ------ Rebuild All started: Project: owbuildid, Configuration: Debug Win32
> ------
> Deleting intermediate and output files for project 'owbuildid', configuration
> 'Debug|Win32'
> Building Custom Rule C:/Projects/wp-2.2/wengophone/src/buildid/CMakeLists.txt
> Subversion (svn) command line not found, it is recommended to install it
> -- OS: Windows-5.0
> -- Processor: x86
> -- Compiler: C:/Program Files/Microsoft Visual Studio 8/VC/bin/cl.exe
> -- Build type: Debug
> -- Build tool: C:/PROGRA~1/MICROS~3/Common7/IDE/VCExpress.exe
> -- Build directory: C:/Projects/wp-2.2/build/debug
> -- svn revision: 13253
> -- Time:
> [snip]
>
> I believe the date-time used by the BUILDID comes from the time field
> which - in my case - is empty. What do I have to do get that value?
> It seems that "OWGetCurrentDateTime.cmake" respectivly a output in
> "getcurrentdatetime.cpp" but I fail to decode what's going on in
> there. (Looks like the cpp is compiled and run out of the
> cmake-build-process; does that work under Windows?)
I'm not a windows user. If you're on windows, you're on your own :)
>
> (Just for reference: I always had the svn revision 0 until I installed
> the command-line version of subversion. After that the svn revision
> was detected correctly.)
Yes, that's how it is designed.
>>> 2. The Visual C++ compiler option "-D" do strip the quotes on the
>>> command line[2] so this must be handled by a define in "phapi.c".
>> That's bad, have you tried to escape them? There should be another way to do
>> that.
>>
>> -DWENGOPHONE_UA="\"wengo/v1/wengophoneng/wengo/rev${SVN_REVISION}/trunk/\""
>>
>> or
>>
>> -DWENGOPHONE_UA='"wengo/v1/wengophoneng/wengo/rev${SVN_REVISION}/trunk/"'
>>
>> or
>>
>> -DWENGOPHONE_UA="'wengo/v1/wengophoneng/wengo/rev${SVN_REVISION}/trunk/'"
>>
>
> Yeah, I also do not like this solution. I've tried your suggestions
> and a lot of other things but I was not able to get around it. Any
> Visual C++-Crack who knows how to fix that?
>
We should create config.h files instead of passing defines via the
commandline. Maybe you want to do that :)
config.h.cmake and ConfigureChecks.cmake is needed. See srtp.
>
> I'll take Thomas' latest revision and work on that one. After that I
> will come back and let the patches be reviewed again...
>
That would be great. It would be great if Thomas would attend to this
discussion :)
> Greetings,
> - Darsha
-- andreas
--
http://www.cynapses.org/ - cybernetic synapses
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Wengophone-devel mailing list [email protected] http://dev.openwengo.com/mailman/listinfo/wengophone-devel
