On Tue, Feb 26, 2008 at 10:19:46PM +0100, Ralf Schlatterbeck wrote: > I'm getting the feeling that my whole advanced config stuff isn't > working, (the dialog *is* working but it seems the values there aren't > used by wengo) any idea if this could be the case? That would explain > that sip.chat.without.presence and sip.p2p... isn't working for me.
I've looked into the code with this suspicion in mind: Chat without presence: - sip.chat.without.presence name in xml file - SIP_CHAT_WITHOUT_PRESENCE name of string in config, only used in wengophone/src/model/config/Config.{cpp,h} - getSipChatWhithouPresence used in Config.{cpp,h} and in main.cpp, there it does a setSipOptions("sip.chat.whithout.presence" (Note the additional "h" in "whithout" !) (shouldn't that have _ instead of . ?) - grepping through the whole tree I've found no instances beyond Config and main where this is actually used. Maybe this *is* missing the implementation? Should I make my earlier patch configurable with this variable? - Patch at the end of this mail corrects spelling: getSipChatWhithouPresence -> getSipChatWithoutPresence sip.chat.whithout.presence -> sip.chat.without.presence without any change in functionality -- chat without presence is still not working. P2P: - sip.p2p.presence name in xml file - SIP_P2P_PRESENCE name of string in config, only used in Config.{cpp,h} - The name SIP_P2P_PRESENCE is also used in an environment-query in libs/sipwrapper/src/phapi/PhApiWrapper.cpp - getSipP2pPresence used in Config.{cpp,h} and in main.cpp, there it does a setSipOptions("sip.p2p_presence" (Note the mix of _ and . !) - libs/sipwrapper/src/phapi/PhApiWrapper.cpp uses: - sipOptions.sip_p2p_presence - the environment-variable SIP_P2P_PRESENCE which sets sipOptions.sip_p2p_presence - PhApiWrapper::setSipOptions looks at an option sip.p2p_presence and seems to set sipOptions.sip_p2p_presence accordingly - I have tried to set environment-variable SIP_P2P_PRESENCE to 1 with no change in functionality. - then I've instrumented the code and it shows sipOptions.sip_p2p_presence to be 1. Note that this time while I had wengo running I had a pop-up that asked me to authorize presence info for a remote (unknown) party. So there seems some support of p2p presence working. I'll now re-test with several clients. Patch: diff -r b37d3c8650e8 wengophone/src/model/config/Config.cpp --- a/wengophone/src/model/config/Config.cpp Tue Feb 26 18:23:02 2008 +0100 +++ b/wengophone/src/model/config/Config.cpp Wed Feb 27 09:50:07 2008 +0100 @@ -530,7 +530,7 @@ bool Config::getSipP2pPresence() const { return getBooleanKeyValue(SIP_P2P_PRESENCE); } -bool Config::getSipChatWhithouPresence() const { +bool Config::getSipChatWithoutPresence() const { return getBooleanKeyValue(SIP_CHAT_WITHOUT_PRESENCE); } diff -r b37d3c8650e8 wengophone/src/model/config/Config.h --- a/wengophone/src/model/config/Config.h Tue Feb 26 18:23:02 2008 +0100 +++ b/wengophone/src/model/config/Config.h Wed Feb 27 09:50:15 2008 +0100 @@ -293,7 +293,7 @@ public: bool getSipP2pPresence() const; static const std::string SIP_CHAT_WITHOUT_PRESENCE; - bool getSipChatWhithouPresence() const; + bool getSipChatWithoutPresence() const; /** @} */ /** diff -r b37d3c8650e8 wengophone/src/presentation/main.cpp --- a/wengophone/src/presentation/main.cpp Tue Feb 26 18:23:02 2008 +0100 +++ b/wengophone/src/presentation/main.cpp Wed Feb 27 09:49:39 2008 +0100 @@ -288,10 +288,10 @@ int main(int argc, char * argv[]) { else w->setSipOptions("sip.p2p_presence", "false"); - if(config.getSipChatWhithouPresence()) - w->setSipOptions("sip.chat.whithout.presence", "true"); - else - w->setSipOptions("sip.chat.whithout.presence", "false"); + if(config.getSipChatWithoutPresence()) + w->setSipOptions("sip.chat.without.presence", "true"); + else + w->setSipOptions("sip.chat.without.presence", "false"); if(config.getSipUseTypingState()) w->setSipOptions("sip.use_typing_state", "true"); Ralf -- Dr. Ralf Schlatterbeck Tel: +43/2243/26465-16 Open Source Consulting Fax: +43/2243/26465-23 Reichergasse 131 www: http://www.runtux.com A-3411 Weidling email: [EMAIL PROTECTED] osAlliance member email: [EMAIL PROTECTED] _______________________________________________ Wengophone-devel mailing list Wengophone-devel@lists.openwengo.com http://dev.openwengo.com/mailman/listinfo/wengophone-devel