Follow-up Comment #4, patch #746 (project wesnoth): Thanks for the code review. I talked a little bit to a couple other devs in #wesnoth, and they don't like the current patch. They believe it's too complicated and the unit bouncing is mostly a non-problem.
I guess I don't have a good enough understanding of the code, but I don't see how to handle various unit manipulations cleanly. How would the iterator know when units it wants to iterate over are moved or killed? How does it know when units are added? How would the iterator know what units have been visited already? I posted about this to the forum at http://www.wesnoth.org/forum/viewtopic.php?t=16695 but I really don't have clear semantics of about units to be able to make a clean implementation. _______________________________________________________ Reply to this item at: <http://gna.org/patch/?746> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Wesnoth-bugs mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-bugs
