Update of patch #797 (project wesnoth):
Status: In Progress => Done
_______________________________________________________
Follow-up Comment #10:
Thank you for the patch, however in the future please try to clean it up a
little bit more. Here's my feedback:
1) always make your patch against the current svn trunk, not an older
version
2) why did you set music_start_time to SDL_GetTicks with fadeout of 0 then
you followed that with an else clause that cannot be reached, however will
immediately prove true next time the function is called (in a matter of
milliseconds)?
3) don't write else { if { } } when you could just write else if { }
4) why did you subtract an unknown amount from an unsigned so that it could
become negative and roll over, then used a greater than / less than
comparison?
5) don't mix tabs with spaces or ignore other style conventions
6) don't add extra information to the header file unless it should be
referenced from another translation unit
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?797>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
