URL:
  <http://gna.org/patch/?825>

                 Summary: selection() returns a negative value
                 Project: Battle for Wesnoth
            Submitted by: microe
            Submitted on: Friday 11/02/2007 at 19:27
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

In the file src/construct_dialog.cpp, in the member function dialog::action,
the function attempts to get the selected item in the menu by calling
selection(). That call can return a negative value. Which will potentially
cause unspecified behavior when the next line tries to remove the item from
the menu list. This patch checks the return value and doesn't attempt the
removal if that value is negative.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Friday 11/02/2007 at 19:27  Name:
selection-can-give-negative-value.patch  Size: 546B   By: microe

<http://gna.org/patch/download.php?file_id=3126>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?825>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to