Follow-up Comment #1, patch #971 (project wesnoth):

Thanks. I'm surprised I never experienced a crash here, do you still have a
traceback of it? But it's a good idea to check in any case.

About the name change, this is out of src/unit.hpp:

        //! The actual name of the unit
        const std::string& name() const { if (description_.empty()) return
language_name(); else return description_; }
        //! The unit type name
        const std::string& description() const { return 
(custom_unit_description_);
}

This is your patch:

-       return Py_BuildValue(STRINGVALUE, unit->unit_->name().c_str());
+       return Py_BuildValue(STRINGVALUE, unit->unit_->description().c_str());

So, I'm confused.. the C++ comments say "unit type name" for description(),
your patch changes it to use description() in order to *not* display the type
name?

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?971>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to