Follow-up Comment #1, patch #1022 (project wesnoth):
While I commend the effort to clean up the code, and make it more testable,
I'm not sure if this kind of patch is likely to be easily accepted from a
first-time contributor.
This patch touches many lines of code, and the only benefit is some
refactoring. A developer would have to read over the patch carefully to make
sure nothing was broken in order to accept it. It is unlikely that any
developers are going to want to spend that much time verifying that the patch
doesn't break anything, as well as that they feel it's an actual improvement
to code quality.
I would suggest trying to implement a less intrusive change for a first-time
committer. Something that adds a new feature or fixes a bug, and preferably
one that's not too intrusive in terms of how much it changes.
Once one becomes a developer, one can try pushing for more refactoring.
--David
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1022>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
