Update of patch #1034 (project wesnoth):
Status: In Progress => None
Assigned to: boucman => None
_______________________________________________________
Follow-up Comment #1:
Looks great overall, just a couple of very minor things:
+ preferences::chat_history().pop_back();
+ preferences::chat_history().push_back(message);
-- this is confusing. Can you please add a comment about how you're popping
back the blank entry and adding the real entry? It might even be clearer to
have, preferences::chat_history().back() = message;
+ alpha_focus_(alpha_focus), history_vector_(NULL)
I'm not sure what the intent is with history_vector_(NULL) but vectors do not
take a pointer as an argument. The NULL is being converted to 0 and it's being
used to construct an empty vector.
However vectors construct to empty by default. Just remove the
history_vector_ from the initialization list altogether.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1034>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
