Follow-up Comment #1, patch #1106 (project wesnoth):

I looked at the patch and left you some questions in IRC, I'll paste them
here just in case you missed them.

[21:04] <Mordante>      Pietro_S what's the problem with __FUNCTION__ ?
[21:08] <Mordante>      also think some namespace changes look odd, some places
you remove std:: and some you add them
[21:09] <Mordante>      expecially std::sprintf looks horrible :/ I think the
proper includes might fix this problem without namespace changes
[21:12] |<--    Rrenys has left freenode (Read error: 104 (Connection reset by
peer))
[21:15] <Mordante>      what's the problem with logger::dont_log in log.hpp?

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?1106>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to