Follow-up Comment #2, patch #1139 (project wesnoth):
Looks good, a couple of comments though
* you have a commented out function, please remove it, we have SVN to find
old code, and commented functions can get confusing
* you should add a changelog entry
* you should add yourself to about.cfg (in the contributor section)
as discussed on IRC, I will wait for the next version of this patch for
commit
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1139>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
