Follow-up Comment #9, patch #1139 (project wesnoth):
Don't worry, I have read your original submission. It explains why you did it
that way, but it doesn't explain why it couldn't be done another way.
For instance, there is an ambiguity caused by t_string::operator=(std::string
const &) and you decided to work around it by putting conversion suffixes. But
you could also have just removed this assignment operator. But perhaps you
noticed an inefficiency since this operator is supposed to be an
optimization. Then a sfinae-based dispatch would solve the performance issue.
But you felt it was not the way to go for your first patch. So you finally
decided on using suffixes.
Don't get me wrong, I'm happy that someone is taking care of this part of the
code; that way I can focus on Lua. But since the config and t_string classes
are one of the backbones of Wesnoth, it is interesting/important to know both
what works and what doesn't work.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1139>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
