Follow-up Comment #2, patch #1175 (project wesnoth):
hello lampak
thx for the patch it's always great to have new contributors around
First a few remarks about the patch itself
* you did not add a changelog entry
* you did not add yourself to about.cfg (as a contributor)
* you seem to have tabs and spaces a bit messed up, please try to follow our
coding style on that
these are fairly minor, the code itself is good
As for the idea itself, you raised an interesting problem, but the discussion
between the devs hasn't concluded yet, and we are not sure if we want to have
an option for that. We might just drop the interruption on sighted allies
entirely (the rational being that if it's important there would be a WML
event)
i'll keep you inform so you can rework your patch accordingly once we have
reached an agrement
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1175>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
