Follow-up Comment #3, patch #1343 (project wesnoth):
ok, good first try BBT, but we'll need at least a cycle with you before
commit
* you don't have a changelog entry
* afaik you don't have an entry in about.cfg you should add yourself
there...
on the code side...
* your code adds an include of <limits> which seems unused
* your new class has a "uhs_compare" method which seems unused
why code a square distance, in src/map_location.hpp there is a
distance_between function which is hex aware.
if you want to do it with square (which I can understand, since it's not the
same idea, the other is walking distance) you should add the distance
comparison function to src/map_location.hpp instead of coding it in your
file
note that walking distance on a hex grid is closer to flying distance than on
a square grid, so the square distance is probably not that useful.
look into all that and we'll get going
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1343>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
