Follow-up Comment #1, patch #1383 (project wesnoth):
The patch introduces some code duplication. From my test, the code /works/,
but it is not ideal from a maintenance standpoint and it is a bit messy.
If the check is added to the is_empty() check above it, OOS errors arise
since it seems to expect the do_replay and finish_side_turn() calls. It may
also be better if it also gets the reset_turn_stats and init_side calls
above, but the former may also be unnecessary since the side is skipped
anyways and the latter *seems* to do no harm if not there, but I may be
missing some finer details.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1383>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
