Follow-up Comment #5, patch #1808 (project wesnoth):
Thanks, I solved all of these points (I think) and current_unit isn't
neccessary although it makes the code somewhat more complicated when querying
whether handle_child is currently called for the toplevel.
However, I suggest several changes to wesnoth.add_modification:
-Is "advance" meant to add an amla-advancement option, so please rename it to
that tag "advancement". Is more intuitive and makes code simpler.
-Can't the syntax just be like
wesnoth.add_modification(u, { {"object", { "effect", { apply_to =
"image_mod", replace = "RC(red>blue)" } } } } )
?
-The unit needs to be a proxy unit, while it would be much more useful if it
could be a wml table too (this is the case with many of the lua functions).
Finally, units from wesnoth.create_unit "loose" x,y values, which makes sense
to me but may not be intended and should be mentioned in the documentation.
(Where do private proxy units live (on the recall list ?), is it only needed
for wenoth.create_unit ?)
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1808>
_______________________________________________
Nachricht geschickt von/durch Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
