Follow-up Comment #7, patch #1877 (project wesnoth):
Patch contents:
pofix.py.diff just contains a diff of the pofix.py I was working from.
cfgs.diff.zip contains diffs of all the affected campaign files.
IMPORTANT NOTE: No namespaces defined. Because Li'Sar's in the text, you
could get interference between e.g. HTTT and the tutorial. The phrase 'Death
of Li'Sar' is an obvious case. There are also generic phrases like 'I don't
know', 'I don't think', which appear in multiple campaigns. When I did my
test run with a namespace of "unspecified", I didn't notice anything
breaking. Is it safe to supply the pofix like this? As a safety feature I've
put in a deliberate error to stop the file running until it's be okayed.
Campaign CFG files currently affected:
Dead_Water
Delfadors_Memoirs
Eastern_Invasion
Heir_To_The_Throne
Legend_of_Wesmere
Northern_Rebirth
Sceptre_of_Fire
Son_Of_The_Black_Eye
The_Hammer_of_Thursagan
The_Rise_Of_Wesnoth
The_South_Guard
tutorial
Under_the_Burning_Suns
DUPLICATE MSGIDs: Anything that caused a 'duplicate msgid' warning has been
commented out.
GETTEXT LINE LENGTH: I spot-checked several files in Poedit 1.4.6, including
the longest line I could find, which was one of the Ro' brothers saying,
"It's your kind that won't leave <i>us</i> alone" (or words to that effect.)
This came to 86 bytes in the POs and I couldn't see any issues. Nevertheless
it's commented out. There's one line at 85, about six at 84, dozens at 83 and
under. I do have a list if needed. Please let me know.
SINGLE-WORD CHANGES: Especially unit names. These seem to be great for
generating spurious duplicate msgids. They're all commented out for now.
PO FILES SANITY CHECK: I also have a list of all the strings direct from the
POTs that contained apostrophes. These should disappear naturally. What I did
as part of my sanity checking was to add the word POTS to the end of each of
these strings, add them to pofix and run it, and then see if any spurious
instances of 'POTS' reappeared anywhere. This didn't happen, so I'm satisfied
that the current contents of pofix do touch all the text intended to be
changed, with just a handful of exceptions for the commented-out lines.
At this point I can't think of anything else to check, but I am still a bit
worried about the gettext line length issue. Let me know if it recurs.
Thanks.
(file #10079, file #10080)
_______________________________________________________
Additional Item Attachment:
File name: cfgs.diff.zip Size:181 KB
File name: pofix.diff Size:36 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1877>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs
