URL:
  <http://gna.org/bugs/?19213>

                 Summary: wesnoth.get_time_of_day behaves incorrectly
                 Project: Battle for Wesnoth
            Submitted by: elvish_hunter
            Submitted on: ven 23 dic 2011 09:19:26 GMT
                Category: Bug
                Severity: 4 - Important
                Priority: 5 - Normal
              Item Group: WML
                  Status: None
                 Privacy: Public
             Assigned to: alink
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 1.9.13+svn
        Operating System: Linux

    _______________________________________________________

Details:

I use wesnoth.get_time_of_day in [harm_unit]. When I tested it on 1.9.12, it
worked by accessing the bonus_modified field, to get the illumination value
after applying the Illuminates ability.
However, on 1.9.13+svn (52358M), I noticed that this is no longer the case.
After the certain commits (52213, 52240, 52241, 52252, 52253), it works
differently.
Before, lawful_bonus returned the ToD bonus without the illumination ability,
and bonus_modified returned the bonus with the ability taken in account.
Now, lawful bonus returns the ToD bonus with the illumination ability taken
in account, and bonus_modified returns the value of the applied modification.
For example, these are the values with a Mage of Light around at night (with
the third parameter as true):

Before: lawful_bonus: -25; bonus_modified: 0
Now: lawful_bonus: 0; bonus_modified: 25

If more testcases are needed, just ask.

In case that the current one, rather than the former one, is the intended
behaviour, the fix for [harm_unit] is pretty straightforward, as it requires
only switching to the lawful_bonus field.




    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?19213>

_______________________________________________
  Messaggio inviato con/da Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to