URL:
  <http://gna.org/bugs/?20604>

                 Summary: [object][effect]apply_to=variation only works
correctly once for each unit
                 Project: Battle for Wesnoth
            Submitted by: shadowmaster
            Submitted on: Sat 09 Mar 2013 05:49:45 AM CLST
                Category: Bug
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Units
                  Status: None
                 Privacy: Public
             Assigned to: jamit
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 1.11.1+svn r56459
        Operating System: Debian wheezy

    _______________________________________________________

Details:

In current Wesnoth trunk r56459, [object][effect]apply_to=variation only works
correctly once for each affected unit.

This is bug most notably results in the unit's baseframe not being updated
anymore after the first variation-affecting object is applied.

I am attaching a WML snippet with example code that creates a unit with a
given variation and applies objects to it in succession to transform it to
various variations accepted by its unit type (in this case, a Walking
Corpse).

This works *mostly* fine [1] on Wesnoth 1.11.1 and earlier (including 1.10.x),
but on current trunk the unit remains with the baseframe and stats for the
first variation applied via [object]. If the unit is initially spawned with a
variation set with the variation= attribute under [unit] directly, it will get
stuck with that variation's baseframe and stats instead and ignore any
subsequent variation-affecting objects.

Using git bisect to test various builds, I found revision 56062 (by jamit) to
be the culprit, but I am not completely sure what the changes involved are,
and probably won't investigate the issue any further since the unit/unit_type
code has always been too dense for my taste. I am not completely sure whether
this is the correct commit either, since I had to skip one commit that
wouldn't compile at all while bisecting.

[1] NOTE: on all aforementioned versions there is a glitch with the unit's
portrait in [message] actions. This is not relevant to this bug report and I
will probably file a separate bug later.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 09 Mar 2013 05:49:45 AM CLST  Name:
variation_object_sequence_test.cfg  Size: 1kB   By: shadowmaster

<http://gna.org/bugs/download.php?file_id=17413>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?20604>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to