Follow-up Comment #1, bug #21746 (project wesnoth):

I fixed the unit_map tests, in that now they no longer segfault / give
division by zero error.

See commit:
https://github.com/cbeck88/wesnoth-old/commit/426721f03f46b9a74387498df065ba1d1687e65e

It still has some failures: The console output associated to the unit map
tests is now:

20140311 20:13:09 error engine: Trying to add  - Orcish Grunt-4294967294 -
4294967294 (2,2) over  - Orcish Grunt-4294967294 - 4294967294 (2,2). The new
unit will be assigned underlying_id=1 to prevent duplicate id conflicts.
20140311 20:13:09 warning unit: assigning new id to clone of generic unit
Orcish Grunt-4294967294
20140311 20:13:09 error engine: Trying to add  - Orcish Grunt-4294967294 at an
invalid location; Discarding.
20140311 20:13:09 error engine: Trying to add  - Orcish Grunt-4294967294 -
4294967294 (2,3) over  - Orcish Grunt-4294967294 - 4294967294 (2,2). The new
unit will be assigned underlying_id=2 to prevent duplicate id conflicts.
20140311 20:13:09 warning unit: assigning new id to clone of generic unit
Orcish Grunt-4294967294
src/tests/test_unit_map.cpp(236): error in "track_real_unit_by_iterator":
Iterator should be invalid after extraction and reinsertion.
src/tests/test_unit_map.cpp(272): error in "track_fake_unit_by_iterator":
Iterator should be invalid after extraction and reinsertion.


So I guess that only the last two messages are being reported by Boost unit
tests, and the others are automatic from the engine and reflect correct
behavior. If so, then the only actually problem above is that iterators are
not being properly invalidated -- not sure what is actually going wrong there.

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?21746>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to