Follow-up Comment #3, bug #21335 (project wesnoth):

Ah I see, I misread your post: "Delay is usually used to time animations that
don't involve units."

I looked up what controls the sign blinking, it is the [delay] command in WML
apparently:

https://github.com/wesnoth/wesnoth/blob/5b72fe99a50bbdece9b540af74c652ab3c7d5a24/data/core/macros/interface-utils.cfg#L36

Such a tag could only be used for animations, if the acceleration setting
doesn't affect it that's pretty clearly a bug imo.

The [delay] tag is "implemented" in lua, but all it does is call C++:

https://github.com/wesnoth/wesnoth/blob/762efc278f645db185963ce97bbc907e4e2b2c59/data/lua/wml-tags.lua#L799

https://github.com/wesnoth/wesnoth/blob/6f4763ce0467c83fd8946c3385306a313f289203/src/scripting/lua.cpp#L3421

I think a reasonable solution is to make the implementation divide the delay
time by the display's turbo speed, similarly to how the unit animations work:
https://github.com/wesnoth/wesnoth/blob/0ebaae5acf4afc8eb0dee59535ae48a968ab7bd5/src/unit_animation.cpp#L1384

Do you agree with this?

Could also add an optional "ignore_acceleration" boolean flag to [delay] but
idk if it should be necessary.

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?21335>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Wesnoth-bugs mailing list
[email protected]
https://mail.gna.org/listinfo/wesnoth-bugs

Reply via email to